Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support featureXRPFees amendment #2219

Closed
ckniffen opened this issue Feb 17, 2023 · 0 comments · Fixed by #2357
Closed

Support featureXRPFees amendment #2219

ckniffen opened this issue Feb 17, 2023 · 0 comments · Fixed by #2357

Comments

@ckniffen
Copy link
Collaborator

ckniffen commented Feb 17, 2023

This amendment is part of [email protected] and updates the fees to be formatted as Amounts.

XRPLF/rippled#4247

  • For server_info favor the following in order
    • reserve_base_drops, reserve_base, reserve_base_xrp
    • base_fee_drops, base_fee, base_fee_xrp
    • reserve_inc_drops, reserve_inc_fee, reserve_inc_fee_xrp
  • If specifically looking for fees such as in the client libraries when autofilling use the command fee which is not changed by this PR and is already in drops.
  • Validations processing will need to be handled similar to server_info.
  • Fee property on all transactions remains the same
  • SetFee transactions
    • BaseFeeDrops, ReserveBaseDrops, and ReserveIncrementDrops will be present when the amendment is passed and on new transactions. These will be of the type Amount
    • BaseFee, ReserveBase, ReferenceFeeUnits, ReserveIncrement are valid only historically after the amendment passes
    • No need for validation updates in client libraries as this is a pseudo transaction
    • Types should reflect there will be only one of the two sets of fields
  • FeeSettings
    • New fields need to be added to the type.
@ckniffen ckniffen mentioned this issue Feb 17, 2023
1 task
ckniffen added a commit that referenced this issue Jun 29, 2023
Adds the new fields for `XRPFees` amendment and id for the `FeeSettings`
singleton ledger entry.

Closes #2219
ckniffen added a commit that referenced this issue Jun 29, 2023
Adds the new fields for `XRPFees` amendment and id for the `FeeSettings`
singleton ledger entry.

Closes #2219
ckniffen added a commit that referenced this issue Jul 3, 2023
Adds the new fields for `XRPFees` amendment and id for the `FeeSettings`
singleton ledger entry.

Closes #2219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants