Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add model tests for new sidechain transactions #2059

Merged
merged 18 commits into from
Sep 25, 2023
Merged

test: add model tests for new sidechain transactions #2059

merged 18 commits into from
Sep 25, 2023

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jul 31, 2022 •
edited
Loading

High Level Overview of Change

Title says it all.

Context of Change

Model tests for #2039. These tests are in a separate PR to make it easier to review, and will be merged into the feature branch prior to merging into main. Any bugfixes that were caught by these tests were moved to #2039.

Type of Change

  • Tests (You added tests for code that already exists, or your new feature included in this PR)

Before / After

Test Plan

Passes locally.

@mvadari mvadari force-pushed the sidechain-2.5-tests branch 3 times, most recently from 02c1185 to 4fb8304 Compare July 31, 2022 15:02
@mvadari mvadari force-pushed the sidechain-2.5-tests branch 7 times, most recently from 2be7f1f to ab8754b Compare September 1, 2022 08:15
@mvadari mvadari force-pushed the sidechain-2.5 branch 2 times, most recently from a59fafb to ee927a1 Compare September 2, 2022 11:07
@mvadari mvadari marked this pull request as ready for review October 13, 2022 15:12
@mvadari mvadari changed the title test: add model tests for new sidechain transactions [DO NOT MERGE] test: add model tests for new sidechain transactions Oct 13, 2022
JST5000
JST5000 reviewed Oct 13, 2022
View reviewed changes
packages/xrpl/test/models/XChainCreateClaimID.ts Outdated
LockingChainDoor: 'rGzx83BVoqTYbGn7tiVAnFw7cbxjin13jL',
LockingChainIssue: 'XRP',
IssuingChainDoor: 'r3kmLJN5D28dHuH8vZNUZpMC43pEHpaocV',
IssuingChainIssue: 'XRP',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a test for if any of these "Locking" fields are missing in the XChainBridge?

JST5000
JST5000 previously approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JST5000
JST5000 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - handy script :)

@intelliot
Copy link
Collaborator

note: this needs review and is blocking #2039

@pdp2121 will you have a chance to review?

@mvadari mvadari merged commit 1a7713b into sidechain-2.5 Sep 25, 2023
15 checks passed
@mvadari mvadari deleted the sidechain-2.5-tests branch September 25, 2023 22:04
mvadari added a commit that referenced this pull request Sep 26, 2023
@mvadari
feat: add support for current sidechain design (#2039)
91e7369 
* Update definitions.json

* add new st types

* add tests

* add XChainClaim tx

* add XChainCommit tx

* add XChainCreateBridge tx

* add XChainCreateClaimID tx

* update definitions.json

* rename Bridge -> XChainBridge in binary codec, fix tests

* rename Bridge -> XChainBridge in models

* add codec support for XChainAddAttestation

* add XChainAddAttestation model

* undo debugging change

* fix linting issues

* update definitions.json for new rippled code, add new tests/update old tests

* add/update models

* update history

* update binary-codec

* add XChainModifyBridge model

* update RPCs

* update to latest rippled

* more fixes

* fix definitions.json

* fix spacing

* update definitions.json to avoid conflict with amm

* update definitions.json to resolve amm conflicts

* audit code

* more updates

* update rpcs

* switch to beta version

* add destination tag to XChainClaim

* rename IssuedCurrency -> Issue to match rippled

* update Issue form

* fix account object filters

* fix issue from typing

* fix LedgerEntry types

* fix attestation destination type

* Update definitions.json

* rename XChainAddAttestation -> XChainAddAttestationBatch

* add XChainAddClaimAttestation

* add XChainAddAccountCreateAttestation

* remove XChainAddAttestationBatch

* update definitions

* fix attestation txns

* fix attestation object

* add validate for new txs

* add Bridge ledger object

* add XChainOwnedClaimID ledger object

* add XChainOwnedCreateAccountClaimID ledger object

* update account_objects

* update models to latest rippled

* fix minor issues

* fix bridge ledger_entry

* add XChainModifyBridge flag

* Update definitions.json

* add rbc tests for the new txs

* update validateXChainModifyBridge

* add validate methods to other xchain txs

* fix isXChainBridge

* fix isIssue typing

* fix model types

* update changelog

* switch prepare to prepublishOnly

* add docs

* fix AccountObjectsType filter

* export common types

* fix account_objects filter

* update LedgerEntry

* add sidechain faucet info

* add snippet

* improve snippet

* fix spacing issues

* update ledger_entry

* remove AMMDelete tests for now

* Update definitions.json

* fix unit tests

* convert createValidate script to JS
* remove unneeded linter ignores

* respond to comments

* more snippet fixes

* make validate functions more readable

* add getXChainClaimID method to parse metadata

* re-add linter rules

* clean up common

* fix getXChainClaimID test

* return undefined for failed tx

* test: add model tests for new sidechain transactions (#2059)

* add XChainAddAttestation tests, fix model

* add XChainClaim model tests

* add XChainCommit model tests, fix typo

* add XChainCreateBridge model tests

* add XChainCreateClaimID model tests

* add XChainModifyBridge tests

* update to most recent version of code

* remove XChainAddAttestationBatch tests

* add more validation tests

* switch createValidateTests to JS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckniffen ckniffen ckniffen approved these changes

@JST5000 JST5000 JST5000 approved these changes

@jonathanlei jonathanlei Awaiting requested review from jonathanlei

@pdp2121 pdp2121 Awaiting requested review from pdp2121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvadari @intelliot @ckniffen @JST5000