-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linter peer dependencies #2168
Conversation
existing.addItem(index, item, leaf) | ||
} else { | ||
throw new Error('invalid ShaMap.addItem call') | ||
if (index !== undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this change from dependabot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I made these changes - this was to deal with the new version of something not recognizing that assert.ok(index !== undefined)
means that index
is ok to use later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The Dependabot PR is separate & I'll close it once this gets merged :) )
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Ignoring: Powered by socket.dev |
@SocketSecurity ignore [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why all the linting changes? Are those part of the eslint config itself?
Yep, they were part of the updated linting config (The 1.9.1 one) |
High Level Overview of Change
Fixes a peer dependency mismatch and addresses a couple old Dependabot issues.
Context of Change
Updating dependencies
Type of Change
Before / After
Updated several packages associated with linting.
Test Plan
CI Passes and can build locally