Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper to get the NFTokenID after minting #2205

Merged
merged 20 commits into from
Feb 21, 2023
Merged

Add a helper to get the NFTokenID after minting #2205

merged 20 commits into from
Feb 21, 2023

Conversation

JST5000
Copy link
Contributor

@JST5000 JST5000 commented Feb 14, 2023

High Level Overview of Change

Add getNFTokenID to parse the metadata after minting an NFT to get the NFTokenID.

Context of Change

Right now it's very complicated to the get the NFTokenID after minting an NFT, which makes it hard to use the other transactions related to that NFT.

Type of Change

  • New feature (non-breaking change which adds functionality)

Before / After

  • Added getNFTokenID to the utils folder
  • Also added an integration test case for NFTokenMint

Test Plan

CI passes

packages/xrpl/src/models/transactions/metadata.ts Outdated Show resolved Hide resolved
packages/xrpl/src/utils/getNFTokenID.ts Outdated Show resolved Hide resolved
packages/xrpl/src/utils/getNFTokenID.ts Outdated Show resolved Hide resolved
packages/xrpl/src/utils/getNFTokenID.ts Show resolved Hide resolved
packages/xrpl/src/utils/getNFTokenID.ts Outdated Show resolved Hide resolved
packages/xrpl/src/utils/getNFTokenID.ts Outdated Show resolved Hide resolved
@JST5000 JST5000 merged commit 5d34746 into main Feb 21, 2023
@JST5000 JST5000 deleted the nftokenid branch February 21, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants