[DO NOT MERGE] feature Hooks
#2217
Conversation
|
Not yet added to the documentation, no need to add an Invoke transaction? |
Invoke is done through |
|
@develoQ Here is an example of how to use the sdk. https:/Transia-RnD/xls-playground/blob/main/ts/test/hooks.test.ts |
|
@dangell7 Great work on this so far! One suggestion is to add a test case for adding For example: {
"NetworkID":21338,
"TransactionType":"Payment",
"Account":"rERZinA8bgHKx1Uu7goWwzJgRFiBx2o3Xg",
"Amount":"10000000",
"Destination":"r3GC3EBBCMbp17pi3NjmfVPAUM7UJuyWiE",
"DestinationTag":160,
"HookParameters":[
{
"HookParameter":{
"HookParameterName":"ABCDEF12",
"HookParameterValue":"12345678"
}
}
],
"Fee":"50000"
} |
dangell7
force-pushed
the
hooks
branch
2 times, most recently
from
7aef2d3
to
49bc75b
Compare
update definitions add network id to base transaction add set hook update required update definitions make network id required
update hook add test and validation add estimate fee func fix estimated fee error add hook utils
|
@dangell7 did you mean to put all these commits in this branch? |
Should be cleaned up now. I'm gonna close this until we get closer to a merge. |
High Level Overview of Change
Add Hooks Amendment Support. A full read me can be found here
Context of Change
Type of Change
This PR adds the
SetHooktransaction and the utility functions for the Hooks Amendment. It also makes changes to the definitions. Finally this PR is rebased off, , which is required on the Hook network.Test Plan
I plan to write the standard tests matching a similar transaction like SignerListSet. There are 2 additional functions that needs to be written. CreateCode takes a binary string compiled from a wasm file and HookOn is a Hash256 compiled of different transaction types. Any additional files should include a test.