Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update xls34 definitions #2333

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Conversation

dangell7
Copy link
Contributor

@dangell7 dangell7 commented Jun 6, 2023

No description provided.

Copy link
Collaborator

@khancode khancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the merge conflicts and then I'll approve?

@dangell7
Copy link
Contributor Author

dangell7 commented Jun 6, 2023

[
      "DiscountedFee",
      {
        "nth": 48,
        "isVLEncoded": false,
        "isSerialized": true,
        "isSigningField": true,
        "type": "UInt32"
      }
    ],

Doesn't exist anymore right? So that needs to be removed.

@khancode
Copy link
Collaborator

khancode commented Jun 6, 2023

[
      "DiscountedFee",
      {
        "nth": 48,
        "isVLEncoded": false,
        "isSerialized": true,
        "isSigningField": true,
        "type": "UInt32"
      }
    ],

Doesn't exist anymore right? So that needs to be removed.

@dangell7 No it still exists, it needs to be changed to 6.

Copy link
Collaborator

@khancode khancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@khancode khancode merged commit b06719c into XRPLF:beta3 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants