Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for server_definitions RPC #2535

Merged
merged 13 commits into from
Oct 31, 2023
Merged

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Oct 20, 2023

High Level Overview of Change

Title says it all.

Context of Change

XRPLF/rippled#4703

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)

Did you update HISTORY.md?

  • Yes

Test Plan

Added tests. Pass in CI.

@@ -16,7 +16,7 @@ export interface NFTInfoRequest extends BaseRequest, LookupByLedgerRequest {
}

/**
* Response expected from an {@link NFTInfoResponse}.
* Response expected from an {@link NFTInfoRequest}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckniffen ckniffen merged commit 14f40f1 into main Oct 31, 2023
17 checks passed
@ckniffen ckniffen deleted the server_definitions branch October 31, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants