feat: Upgrade to Node 18 and remove cross-fetch #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@noble/[email protected], npm/@scure/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected] |
jonathanlei
approved these changes
Apr 4, 2024
|
This should be done in a major version bump. |
BREAKING CHANGE: fetch now relies on the native javascript environment in browsers and node.js
|
FYI: Node 18 has LTS support only until April 2025. We will need to perform a similar obviation of Node 18 at that time |
In the past, for the most part we keep support for the version until we need to remove it or until it's super old. |
9 tasks
justinr1234
added a commit
that referenced
this pull request
Jul 16, 2024
* feat: Upgrade to Node 18 and remove cross-fetch BREAKING CHANGE: fetch now relies on the native javascript environment in browsers and node.js * fix typo in HISTORY.md file --------- Co-authored-by: Chenna Keshava B S <[email protected]>
ckeshava
added a commit
that referenced
this pull request
Jul 16, 2024
* feat: Upgrade to Node 18 and remove cross-fetch (#2678) BREAKING CHANGE: fetch now relies on the native javascript environment in browsers and node.js Co-authored-by: justinr1234 <[email protected]>
ckeshava
added a commit
to ckeshava/xrpl.js
that referenced
this pull request
Aug 23, 2024
* feat: Upgrade to Node 18 and remove cross-fetch BREAKING CHANGE: fetch now relies on the native javascript environment in browsers and node.js * fix typo in HISTORY.md file --------- Co-authored-by: Chenna Keshava B S <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fixes #2676
Type of Change
Did you update HISTORY.md?
Test Plan
Automated tests