Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to the hooks testnet faucet in xrpl.js codebase #2711

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

ckeshava
Copy link
Collaborator

High Level Overview of Change

as stated in the title

Context of Change

The reference to asf-flags pertaining to the Hooks amendment have not been removed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Certain tests pertaining to hooks testnet faucet have been removed.

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

Test Plan

No need to add additional tests, this PR removes code.

@ckeshava ckeshava merged commit 02e2b0e into XRPLF:main Jun 21, 2024
15 checks passed
@pdp2121 pdp2121 mentioned this pull request Aug 23, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants