Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHub checks missing from AspNetCore.HealthChecks.AzureServiceBus #2128

Closed
aelghoneimy opened this issue Dec 15, 2023 · 5 comments
Closed
Assignees
Labels
documentation An issue or pull request regarding documentation improvements
Milestone

Comments

@aelghoneimy
Copy link

Please, fill the following sections to help us fix the issue

What happened: Missing AddAzureEventHub health check extension after updating to v8

How to reproduce it (as minimally and precisely as possible): Update AspNetCore.HealthChecks.AzureServiceBus to v8

Source code sample:

healthChecksBuilder.AddAzureEventHub("CONNECTION_STRING", "ENTITY_NAME");
@unaizorrilla
Copy link
Collaborator

We have a new package for this, right @adamsitnik ??

@aelghoneimy
Copy link
Author

In the readme, it's mentioning v8 and EventHub in the AzureServiceBus package

image

@marioleed
Copy link
Contributor

@adamsitnik adamsitnik self-assigned this Dec 18, 2023
@adamsitnik adamsitnik added the documentation An issue or pull request regarding documentation improvements label Dec 18, 2023
@adamsitnik adamsitnik added this to the V 8.0 milestone Dec 18, 2023
@adamsitnik
Copy link
Collaborator

@marioleed is right, the new package for Azure Event Hub is https://www.nuget.org/packages/AspNetCore.HealthChecks.Azure.Messaging.EventHubs

I've updated the docs in #2131

@mikocot
Copy link

mikocot commented Dec 20, 2023

To be fair I can expect more people running into this (just like me), cause there doesn't seem to be any hint about this change, or any information at all about the release of v 8.0. Also, quick google search and docs search doesn't easily get you to

https:/Xabaril/AspNetCore.Diagnostics.HealthChecks/tree/master/src/HealthChecks.Azure.Messaging.EventHubs#breaking-changes if what you've been using so far is the ServiceBus package. Probably it's different for the new users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An issue or pull request regarding documentation improvements
Projects
None yet
Development

No branches or pull requests

5 participants