Fix governance vote purge #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tequdev
commented
Jan 17, 2024
tequdev
commented
Jan 18, 2024
tequdev
commented
Jan 18, 2024
tequdev
commented
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fixed
previous_memberandvote_keyare set correctly when deleting votes in Governance Hook.Context of Change
The implementation didn't match the top comment in the govern.c file.
Fixed existence comparison conditions.
Type of Change
If each governance table continues to use this governance Hook, it is recommended that the Hook be updated.
Test Plan
Since the author is not familiar with C++ code and cannot write sufficient test code, so used JS for the test instead.
https:/tequdev/xahau-governance-hook-test