Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config refactor #298

Merged
merged 48 commits into from
Feb 26, 2020
Merged

Config refactor #298

merged 48 commits into from
Feb 26, 2020

Commits on Feb 18, 2020

  1. First go with having function in the configuration.py

    @antalszava
    antalszava committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    7e67e68 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. First draft

    @antalszava
    antalszava committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    0efccb6 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Logic of load_config before testing

    @antalszava
    antalszava committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    24952e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. Testing config object creation, look_for_config_file function

    @antalszava
    antalszava committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    7d62a23 View commit details
    Browse the repository at this point in the history

  2. Unit tests for the parts making up load_config

    @antalszava
    antalszava committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    e44a1b7 View commit details
    Browse the repository at this point in the history

  3. Unit test for load_config; removing MagicMock from parse_environment_… 

    …variable test; adding teardown logic for env vars; correcting typo
    @antalszava
    antalszava committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    e0afae1 View commit details
    Browse the repository at this point in the history

  4. Marking xfail API Client tests (being refactored in another PR)

    @antalszava
    antalszava committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    3ca6a5b View commit details
    Browse the repository at this point in the history

  5. Marking xfail API Client tests (being refactored in another PR)

    @antalszava
    antalszava committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    abdc0af View commit details
    Browse the repository at this point in the history

  6. Adding xfail mark on another API Client test

    @antalszava
    antalszava committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    2995cd9 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Docstrings, reorganizing parse_environment_variables function, adding… 

    … DEFAULT_CONFIG as module attribute
    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    0770172 View commit details
    Browse the repository at this point in the history

  2. Add create config object test with every keyword argument

    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    e7eb96a View commit details
    Browse the repository at this point in the history

  3. Adding load_config tests using each units separately; change logic fo… 

    …r kwargs update; add logic for integer parsing from env vars; add tests
    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    7bc48ca View commit details
    Browse the repository at this point in the history

  4. Test docstrings

    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    fc5619a View commit details
    Browse the repository at this point in the history

  5. Default config refactor

    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    9109a46 View commit details
    Browse the repository at this point in the history

  6. Add absolute path test

    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    653f566 View commit details
    Browse the repository at this point in the history

  7. Saving path, linting, isort

    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    984c5a5 View commit details
    Browse the repository at this point in the history

  8. Modify dict formatting in docstring

    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    b90ca00 View commit details
    Browse the repository at this point in the history

  9. Update tests/frontend/test_configuration.py 

    Co-Authored-By: Nathan Killoran <[email protected]>
    @antalszava @co9olguy
    antalszava and co9olguy authored Feb 24, 2020
    Configuration menu
    Copy the full SHA
    18a5d33 View commit details
    Browse the repository at this point in the history

  10. Modifying docstrings based on comments

    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    42071b0 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'config_refactor' of https:/XanaduAI/strawbe… 

    …rryfields into config_refactor
    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    ec800c3 View commit details
    Browse the repository at this point in the history

  12. Modifying tests such that look_for_config_in_file returns a tuple; 

    adding user_config_dir mocking logic to test
    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    c2e79d4 View commit details
    Browse the repository at this point in the history

  13. Update tests/frontend/test_configuration.py 

    Co-Authored-By: Nathan Killoran <[email protected]>
    @antalszava @co9olguy
    antalszava and co9olguy authored Feb 24, 2020
    Configuration menu
    Copy the full SHA
    b912be1 View commit details
    Browse the repository at this point in the history

  14. Updating test data

    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    2cef067 View commit details
    Browse the repository at this point in the history

  15. Update tests/frontend/test_configuration.py 

    Co-Authored-By: Nathan Killoran <[email protected]>
    @antalszava @co9olguy
    antalszava and co9olguy authored Feb 24, 2020
    Configuration menu
    Copy the full SHA
    39538d3 View commit details
    Browse the repository at this point in the history

  16. Update strawberryfields/configuration.py 

    Co-Authored-By: Nathan Killoran <[email protected]>
    @antalszava @co9olguy
    antalszava and co9olguy authored Feb 24, 2020
    Configuration menu
    Copy the full SHA
    b5e8229 View commit details
    Browse the repository at this point in the history

  17. Update strawberryfields/configuration.py 

    Co-Authored-By: Nathan Killoran <[email protected]>
    @antalszava @co9olguy
    antalszava and co9olguy authored Feb 24, 2020
    Configuration menu
    Copy the full SHA
    47e483a View commit details
    Browse the repository at this point in the history

  18. Merge branch 'config_refactor' of https:/XanaduAI/strawbe… 

    …rryfields into config_refactor
    @antalszava
    antalszava committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    66ad7da View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Update strawberryfields/configuration.py 

    Co-Authored-By: Nathan Killoran <[email protected]>
    @antalszava @co9olguy
    antalszava and co9olguy authored Feb 25, 2020
    Configuration menu
    Copy the full SHA
    f8e2c29 View commit details
    Browse the repository at this point in the history

  2. Docstring and comment

    @antalszava
    antalszava committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    03e2e04 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'config_refactor' of https:/XanaduAI/strawbe… 

    …rryfields into config_refactor
    @antalszava
    antalszava committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    4fa68ad View commit details
    Browse the repository at this point in the history

  4. Docstrings, renaming to load_config_file_if_found, adding defaults to… 

    … module level attributes
    @antalszava
    antalszava committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    1f04d5c View commit details
    Browse the repository at this point in the history

  5. Change function to get_config_filepath and adjust tests as well accor… 

    …dingly; change load_config using it
    @antalszava
    antalszava committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    b82c60f View commit details
    Browse the repository at this point in the history

  6. Renaming create_config

    @antalszava
    antalszava committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    544b60c View commit details
    Browse the repository at this point in the history

  7. Modifying tests to use setenv from monkeypatching in tests

    @antalszava
    antalszava committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    228a0c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Adding configuration options and environment variables to module docs… 

    …tring, inserting refs to these in function docstrings, correcting Kwargs section naming in docstrings
    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    4614d83 View commit details
    Browse the repository at this point in the history

  2. Removing redundant return None statement

    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    09a3b3d View commit details
    Browse the repository at this point in the history

  3. Remove update_config function, add keep_valid_options function and ad… 

    …d tests
    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    ef68ab5 View commit details
    Browse the repository at this point in the history

  4. Addig DEFAULT_CONFIG_SPEC

    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    3ca025e View commit details
    Browse the repository at this point in the history

  5. Removed debug option for now

    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    3772015 View commit details
    Browse the repository at this point in the history

  6. Update strawberryfields/configuration.py 

    Co-Authored-By: Josh Izaac <[email protected]>
    @antalszava @josh146
    antalszava and josh146 authored Feb 26, 2020
    Configuration menu
    Copy the full SHA
    d21f3fe View commit details
    Browse the repository at this point in the history

  7. Update strawberryfields/configuration.py 

    Co-Authored-By: Josh Izaac <[email protected]>
    @antalszava @josh146
    antalszava and josh146 authored Feb 26, 2020
    Configuration menu
    Copy the full SHA
    7c73d5c View commit details
    Browse the repository at this point in the history

  8. Moving configuration details to page, updating the configuration page… 

    … with kwargs, adding port to file and env vars
    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    47eac17 View commit details
    Browse the repository at this point in the history

  9. Resolving conflicts

    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    7bb97c8 View commit details
    Browse the repository at this point in the history

  10. Update strawberryfields/configuration.py 

    Co-Authored-By: Josh Izaac <[email protected]>
    @antalszava @josh146
    antalszava and josh146 authored Feb 26, 2020
    Configuration menu
    Copy the full SHA
    e0938a9 View commit details
    Browse the repository at this point in the history

  11. Applying comments: Configuration page modification, removing redundan… 

    …t module attributes, reword module docstring
    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    17be8bb View commit details
    Browse the repository at this point in the history

  12. Merge branch 'config_refactor' of https:/XanaduAI/strawbe… 

    …rryfields into config_refactor
    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    3d2aa7d View commit details
    Browse the repository at this point in the history

  13. CHANGELOG

    @antalszava
    antalszava committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    6635879 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'demo' into config_refactor

    @antalszava
    antalszava authored Feb 26, 2020
    Configuration menu
    Copy the full SHA
    0063663 View commit details
    Browse the repository at this point in the history