Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds improved Bloch-Messiah that gives correct results when the symplectic matrix is degenerate #352

Merged
merged 13 commits into from
Sep 6, 2022
Merged

Adds improved Bloch-Messiah that gives correct results when the symplectic matrix is degenerate #352

merged 13 commits into from
Sep 6, 2022

Conversation

nquesada
Copy link
Collaborator

This is related to this issue: XanaduAI/strawberryfields#728

@codecov
Copy link

codecov bot commented Aug 19, 2022 •
edited
Loading

Codecov Report

Merging #352 (b68a7ba) into master (9d8fe40) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #352   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1737      1761   +24     
=========================================
+ Hits          1737      1761   +24
Impacted Files Coverage Δ
thewalrus/decompositions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8fe40...b68a7ba. Read the comment docs.

@sduquemesa sduquemesa changed the title Adds improved Bloch-Messiah that gives correct results when the symplectic matrix is degenrate Adds improved Bloch-Messiah that gives correct results when the symplectic matrix is degenerate Aug 22, 2022
sduquemesa
sduquemesa suggested changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@sduquemesa sduquemesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution! We'll use this implementation on strawberryfields once merged.

There are some comments that need to be addressed though.

thewalrus/tests/test_decompositions.py Outdated Show resolved Hide resolved
thewalrus/tests/test_decompositions.py Outdated Show resolved Hide resolved
thewalrus/decompositions.py Outdated Show resolved Hide resolved
thewalrus/decompositions.py Outdated Show resolved Hide resolved
thewalrus/tests/test_decompositions.py Outdated Show resolved Hide resolved
@sduquemesa sduquemesa added the enhancement New feature or request label Aug 22, 2022
@sduquemesa sduquemesa assigned sduquemesa and nquesada and unassigned sduquemesa and nquesada Aug 22, 2022
@sduquemesa sduquemesa self-requested a review September 6, 2022 18:22
@sduquemesa sduquemesa merged commit ec2d93f into XanaduAI:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduquemesa sduquemesa sduquemesa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nquesada @sduquemesa @MHoude2