Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] remove unnecessary fields in log #585

Open
wants to merge 4 commits into
base: dev-upgrade
Choose a base branch
from

Conversation

JukLee0ira
Copy link

@JukLee0ira JukLee0ira commented Jul 17, 2024

Proposed changes

fix #570

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@JukLee0ira JukLee0ira force-pushed the opt-receipt-storage branch 2 times, most recently from 525a819 to 967f7cd Compare July 17, 2024 10:05
@JukLee0ira JukLee0ira marked this pull request as ready for review July 17, 2024 10:19
@JukLee0ira JukLee0ira changed the title remove unnecessary fields in log [WIP]remove unnecessary fields in log Jul 18, 2024
@JukLee0ira JukLee0ira changed the title [WIP]remove unnecessary fields in log [WIP] remove unnecessary fields in log Jul 18, 2024
@JukLee0ira JukLee0ira force-pushed the opt-receipt-storage branch 3 times, most recently from 01d28fe to ce6f8d8 Compare July 18, 2024 14:57
@JukLee0ira JukLee0ira changed the title [WIP] remove unnecessary fields in log remove unnecessary fields in log Jul 18, 2024
@JukLee0ira JukLee0ira changed the title remove unnecessary fields in log [WIP]remove unnecessary fields in log Jul 18, 2024
@JukLee0ira JukLee0ira force-pushed the opt-receipt-storage branch 2 times, most recently from 265059a to 008ee86 Compare July 19, 2024 06:17
@JukLee0ira JukLee0ira changed the title [WIP]remove unnecessary fields in log remove unnecessary fields in log Jul 19, 2024
@gzliudan
Copy link
Collaborator

We need to study issue #570 carefully, then make a detailed plan.

@gzliudan gzliudan self-requested a review July 22, 2024 10:46
@gzliudan gzliudan changed the title remove unnecessary fields in log WIP: remove unnecessary fields in log Jul 29, 2024
@gzliudan gzliudan changed the title WIP: remove unnecessary fields in log [WIP] remove unnecessary fields in log Sep 9, 2024
@JukLee0ira JukLee0ira force-pushed the opt-receipt-storage branch 6 times, most recently from ce16130 to e2516dc Compare September 20, 2024 07:47
@JukLee0ira JukLee0ira force-pushed the opt-receipt-storage branch 2 times, most recently from 1012f8b to b5cc9bf Compare September 25, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants