Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
PR 20830 separate consensus errors and EVM Internal errors.Since EVM errors have already been separated in #200 , this PR will embed EVM errors into the
executionResult
structure, following the upstream code.Test
Gas Consumption Comparison
Before this PR is merged:
http://127.0.0.1:8545
– The changes from this PR are applied.https://rpc.apothem.network/
– The changes from this PR are not applied.Request:
Response:
Request:
Response:
Revert Logic Test
The following test contract was authored by @gzliudan ,originates from #200.
Request
Response
Request
Response
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that