Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ / 🐛 Spawn Literal Any Dialog on Dragging from Dynaports + Fix Compulsory InPorts with DynaPorts #347

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

MFA-X-AI
Copy link
Member

Description

This PR focuses on dynaport features, in particular:

  • spawns a Literal Any input dialogue when dragging from dynaports. Previously nothing would happen.
  • fixes the interaction between dynaports and compulsory arguments. Previously using InCompArg with dynalist or dynatuples would prevent you from compiling the workflow as each port will be forced to be connected, but will infinitely spawn on new links.

References

#265

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Drag out a link from a dynaport. Verify that a Literal Any input dialogue spawns. Ensure that it works as expected and compiles correctly.
  2. Use a compulsory InArg port with a dynalist or dynatuple. Verify that:
  • on the next spawn port spawned, it will not be a compulsory port ★
  • the on delete of the links connected to the dynaport, the dynaports behavior is consistent, eg:
  • When a link to a dynaport is removed, the following dynaports are automatically updated.
  • If a link is created to a dynaport that already has a link, the new link assumes the current dynaport, and the existing link, along with the following dynaports, are shifted.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Add if any.

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/dyna-fixes

@MFA-X-AI MFA-X-AI merged commit 9c0bdc9 into master Jul 30, 2024
9 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/dyna-fixes branch July 30, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants