Add no_std flag, hide blocking retrys behind std flag #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 27, 2024
|
Thanks a lot for the contribution! |
|
Hi, I have added blocking sleeper in #138. Would you like to try again? |
adrian-kong
commented
Aug 30, 2024
adrian-kong
commented
Aug 30, 2024
| @@ -24,7 +24,7 @@ impl<F: Fn(Duration) + 'static> BlockingSleeper for F { | |||
| /// The default implementation of `Sleeper` when no features are enabled. | |||
| /// | |||
| /// It will fail to compile if a containing [`Retry`][crate::Retry] is `.await`ed without calling [`Retry::sleep`][crate::Retry::sleep] to provide a valid sleeper. | |||
| #[cfg(all(not(feature = "tokio-sleep"), not(feature = "gloo-timers-sleep")))] | |||
There was a problem hiding this comment.
huh this was not compiling for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nice library
resolves #105
Changes:
no_stdbut blocking implementatin behindstddue to thread sleep/.ideato gitignore