Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add deprecation notice #21

Merged
merged 2 commits into from
Jan 13, 2023
Merged

feat: Add deprecation notice #21

merged 2 commits into from
Jan 13, 2023

Conversation

podarok
Copy link

@podarok podarok commented Jan 11, 2023 •
edited
Loading

@podarok podarok self-assigned this Jan 11, 2023
shelleygoetz
shelleygoetz reviewed Jan 11, 2023
View reviewed changes
Copy link

@shelleygoetz shelleygoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @podarok !

froboy
froboy requested changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@froboy froboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@podarok see comment. Looks mostly good just some tweaks.

@podarok podarok merged commit 2794429 into main Jan 13, 2023
@podarok podarok deleted the gxp_to_daxko branch January 13, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shelleygoetz shelleygoetz shelleygoetz left review comments

@froboy froboy froboy requested changes

Assignees

@podarok podarok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@podarok @froboy @shelleygoetz