Skip to content

Commit

Permalink
Merge pull request #970 from Yamato-Security/969-sort-filtering-options
Browse files Browse the repository at this point in the history
sorted filtering options
  • Loading branch information
YamatoSecurity authored Mar 18, 2023
2 parents fbfa1a1 + 5218fc9 commit af08345
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG-Japanese.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- `csv-timeline`の出力のフィールドでダブルクォートを追加した。 (#965) (@hitenkoku)
- `logon-summary`の見出しを更新した。 (#964) (@yamatosecurity)
- `--enable-deprecated-rules``-D`ショートオプションと`--enable-unsupported-rules``-u`ショートオプションを追加した。(@yamatosecurity)
- Filteringセクションのオプションの表示順とヘルプの表示内容を修正した。 (#969) (@hitenkoku)

**Bug Fixes:**

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Added double quotes in CSV fields of `csv-timeline` output to support multiple lines in fields. (#965) (@hitenkoku)
- Updated `logon-summary` headers. (#964) (@yamatosecurity)
- Added short-hand option `-D` for `--enable-deprecated-rules` and `-u` for `--enable-unsupported-rules`. (@yamatosecurity)
- Reordered option in Filtering and Changed option help contents. (#969) (@hitenkoku)

**Bug Fixes:**

Expand Down
16 changes: 8 additions & 8 deletions src/detections/configs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -732,16 +732,16 @@ pub struct PivotKeywordOption {
#[clap(flatten)]
pub common_options: CommonOptions,

/// Enable rules marked as deprecated
/// Enable rules with status of deprecated
#[arg(help_heading = Some("Filtering"), short = 'D', long = "enable-deprecated-rules", display_order = 310)]
pub enable_deprecated_rules: bool,

/// Enable rules marked as unsupported
/// Enable rules with status of unsupported
#[arg(help_heading = Some("Filtering"), short = 'u', long = "enable-unsupported-rules", display_order = 312)]
pub enable_unsupported_rules: bool,

/// Ignore rules according to status (ex: experimental) (ex: stable,test)
#[arg(help_heading = Some("Filtering"), long = "exclude-status", value_name = "STATUS", use_value_delimiter = true, value_delimiter = ',', display_order = 313)]
#[arg(help_heading = Some("Filtering"), long = "exclude-status", value_name = "STATUS", use_value_delimiter = true, value_delimiter = ',', display_order = 314)]
pub exclude_status: Option<Vec<String>>,

/// Minimum level for rules (default: informational)
Expand All @@ -766,7 +766,7 @@ pub struct PivotKeywordOption {
)]
pub exact_level: Option<String>,

/// Enable rules marked as noisy (./rules/config/noisy_rules.txt)
/// Enable rules set to noisy (./rules/config/noisy_rules.txt)
#[arg(help_heading = Some("Filtering"), short = 'n', long = "enable-noisy-rules", display_order = 311)]
pub enable_noisy_rules: bool,

Expand Down Expand Up @@ -844,16 +844,16 @@ pub struct OutputOption {
#[clap(flatten)]
pub common_options: CommonOptions,

/// Enable rules marked as deprecated
/// Enable rules with status of deprecated
#[arg(help_heading = Some("Filtering"), short = 'D', long = "enable-deprecated-rules", display_order = 310)]
pub enable_deprecated_rules: bool,

/// Enable rules marked as unsupported
/// Enable rules with status of unsupported
#[arg(help_heading = Some("Filtering"), short = 'u', long = "enable-unsupported-rules", display_order = 312)]
pub enable_unsupported_rules: bool,

/// Ignore rules according to status (ex: experimental) (ex: stable,test)
#[arg(help_heading = Some("Filtering"), long = "exclude-status", value_name = "STATUS", use_value_delimiter = true, value_delimiter = ',', display_order = 312)]
#[arg(help_heading = Some("Filtering"), long = "exclude-status", value_name = "STATUS", use_value_delimiter = true, value_delimiter = ',', display_order = 314)]
pub exclude_status: Option<Vec<String>>,

/// Minimum level for rules (default: informational)
Expand All @@ -878,7 +878,7 @@ pub struct OutputOption {
)]
pub exact_level: Option<String>,

/// Enable rules marked as noisy (./rules/config/noisy_rules.txt)
/// Enable rules set to noisy (./rules/config/noisy_rules.txt)
#[arg(help_heading = Some("Filtering"), short = 'n', long = "enable-noisy-rules", display_order = 311)]
pub enable_noisy_rules: bool,

Expand Down

0 comments on commit af08345

Please sign in to comment.