Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Info alert shows up twice in Results Summary #1031

Closed
YamatoSecurity opened this issue May 5, 2023 · 2 comments · Fixed by #1032
Closed

[bug] Info alert shows up twice in Results Summary #1031

YamatoSecurity opened this issue May 5, 2023 · 2 comments · Fixed by #1032
Assignees
@hitenkoku
Labels
bug Something isn't working
Milestone
v2.5.0

Comments

@YamatoSecurity
Copy link
Collaborator

Describe the bug
When only running one rule, the alert shows up twice in the Results Summary.

Step to Reproduce
hayabusa.exe csv-timeline -d ../hayabusa-sample-evtx -r ../hayabusa-rules/hayabusa/builtin/BitsClient_Op/BitsCli_59_Info_BitsJobCreated.yml

Expected behavior
It should only show once.

Screenshots
Screen Shot 2023-05-05 at 9 34 27 AM

Environment (please complete the following information):

  • OS: mac
  • hayabusa version: 2.3.3+

This bug does not occur on 2.3.2 and earlier.

@hitenkoku Can you take a look at this? It started to happen in version 2.3.3
@YamatoSecurity YamatoSecurity added the bug Something isn't working label May 5, 2023
@YamatoSecurity YamatoSecurity added this to the v2.5.0 milestone May 5, 2023
@YamatoSecurity
Copy link
Collaborator Author

Additional info: it seems like it is showing the number 1 - 5 alerts twice, instead of 1-10 alerts.
Command: hayabusa.exe csv-timeline -d ../hayabusa-sample-evtx
Screen Shot 2023-05-05 at 1 39 24 PM

hitenkoku added a commit that referenced this issue May 5, 2023
@hitenkoku
fix(fixed informational alert shows up twice in results summary #1031):
c822a14
hitenkoku added a commit that referenced this issue May 5, 2023
@hitenkoku
docs(CHANGELOG): updated changelog #1031
2ef41ff
@hitenkoku hitenkoku linked a pull request May 5, 2023 that will close this issue
Fixed bug info alert shows up twice in results summary #1032
Merged
@hitenkoku
Copy link
Collaborator

Sorry for the delay in replying.

The fix was completed in #1032.
Could you please review it?

hitenkoku added a commit that referenced this issue May 5, 2023
@hitenkoku
docs(CHANGELOG): updated changelog in changelog.md #1031
f65f7f6
hitenkoku added a commit that referenced this issue May 5, 2023
@hitenkoku
UI(afterfact): reverted show order #1031
2e7e107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitenkoku hitenkoku

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

Fixed bug info alert shows up twice in results summary Yamato-Security/hayabusa
2 participants
@hitenkoku @YamatoSecurity