Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics enchancement: make channel name case-insensitive #1066

Closed
YamatoSecurity opened this issue May 31, 2023 · 0 comments · Fixed by #1085
Closed

Metrics enchancement: make channel name case-insensitive #1066

YamatoSecurity opened this issue May 31, 2023 · 0 comments · Fixed by #1085
Assignees
@garigariganzy
Labels
enhancement New feature or request
Milestone
v2.6.0

Comments

@YamatoSecurity
Copy link
Collaborator

Screen Shot 2023-06-01 at 7 14 55 AM

Sometimes the channel name will be all lower case for some reason. So we should probably treat the channel names in rules/config/channel_abbreviations.txt and rules/config/channel_abbreviations_generic.txt as case-insensitive.

Note: I want the output to be the same case-sensitive.
So if microsoft is in the channel name, it should be outputted as MS.
@hitenkoku hitenkoku assigned hitenkoku and garigariganzy and unassigned hitenkoku Jun 1, 2023
@hitenkoku hitenkoku added the enhancement New feature or request label Jun 1, 2023
@YamatoSecurity YamatoSecurity added this to the v2.6.0 milestone Jun 3, 2023
garigariganzy added a commit that referenced this issue Jun 6, 2023
@garigariganzy
WIP:make channel name case-insensitive #1066
2472ab4
@hitenkoku hitenkoku linked a pull request Jun 7, 2023 that will close this issue
make channel name case-insensitive #1066 #1085
Merged
YamatoSecurity added a commit that referenced this issue Jun 7, 2023
@YamatoSecurity
Merge pull request #1085 from Yamato-Security/feature/1066-metrics-ma…
24d42cf 
…ke-channnel-name-case-insensitive

make channel name case-insensitive #1066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garigariganzy garigariganzy

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

make channel name case-insensitive #1066 Yamato-Security/hayabusa
3 participants
@hitenkoku @garigariganzy @YamatoSecurity