Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support en-dash and other permutations for windash #1392

Closed
YamatoSecurity opened this issue Aug 9, 2024 · 0 comments · Fixed by #1393
Closed

Support en-dash and other permutations for windash #1392

YamatoSecurity opened this issue Aug 9, 2024 · 0 comments · Fixed by #1393
Assignees
@hitenkoku
Labels
enhancement New feature or request
Milestone
v2.17.0

Comments

@YamatoSecurity
Copy link
Collaborator

The windash modifier now creates other permutations: – (en dash),— (em dash), and ― (horizontal bar) characters so I would like to add these to check as well.

Reference: https:/SigmaHQ/sigma-specification/blob/main/appendix/sigma-modifiers-appendix.md
@YamatoSecurity YamatoSecurity added the enhancement New feature or request label Aug 9, 2024
@YamatoSecurity YamatoSecurity added this to the v2.17.0 milestone Aug 9, 2024
hitenkoku added a commit that referenced this issue Aug 9, 2024
@hitenkoku
feat(matchers): added en-dash and other permutations for windash modi…
5868144 
…fier #1392
@hitenkoku hitenkoku linked a pull request Aug 9, 2024 that will close this issue
feat(matchers): added en-dash and other permutations for windash modifier #1393
Merged
hitenkoku added a commit that referenced this issue Aug 9, 2024
@hitenkoku
style(matchers): fixed clippy warning #1392
bb3bb6e
hitenkoku added a commit that referenced this issue Aug 10, 2024
@hitenkoku
fix(matchers): fixed windash modifier #1392
090e153
hitenkoku added a commit that referenced this issue Aug 10, 2024
@hitenkoku
test(matchers): fixed windash modifier test #1392
10f3971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitenkoku hitenkoku

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.17.0
Development

Successfully merging a pull request may close this issue.

feat(matchers): added en-dash and other permutations for windash modifier Yamato-Security/hayabusa
2 participants
@hitenkoku @YamatoSecurity