add support for |all
#1060
Merged
add support for |all
#1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
+ Coverage 74.00% 74.22% +0.21%
==========================================
Files 24 24
Lines 18186 18360 +174
==========================================
+ Hits 13459 13628 +169
- Misses 4727 4732 +5
☔ View full report in Codecov by Sentry. |
kazuminn
requested review from
hitenkoku,
itiB and
YamatoSecurity
and removed request for
itiB
|
レビューお願いします。 |
fukusuket
approved these changes
May 30, 2023
There was a problem hiding this comment.
以下3点を確認しました！LGTMです！！🚀
-
修正前後で
csv-timeline -d sample-hayabusa-evtx --debugの結果ファイル差分なし。メモリ使用量同等 -
以下ルールの検知数と
search --keywords mimikatzの件数が一致
detection:
selection:
'|all':
- mimikatz
condition: selection
- 以下ルールの検知数と
search --keywords mimikatz+cat result.csv | grep -i invoke | wc -lの件数が一致
detection:
selection:
'|all':
- invoke
- mimikatz
condition: selection
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
hitenkoku
requested changes
May 30, 2023
YamatoSecurity
approved these changes
May 31, 2023
|
@kazuminn 対応ありがとうございます！念のために確認ですが、 |
|
@YamatoSecurity はい。対応してます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
fix #1038
Evidence
I done a new test.
すでに、all識別子があったので、かぶらないように、allOnly識別子を追加しています。。
計算量は、既存のor andと同じです。すべてのキーワードのデータが一つになっているメンバがあったので、それを渡すようにしています。