Fixed --timeline-start and --timeline-end do not work correctly with json-timeline command.
#1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly with json-timeline #1148
hitenkoku
changed the title
--timeline-start and --timeline-end do not work correctly with json-timeline command.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
=======================================
Coverage 83.17% 83.17%
=======================================
Files 26 26
Lines 22618 22618
=======================================
Hits 18812 18812
Misses 3806 3806
☔ View full report in Codecov by Sentry. |
YamatoSecurity
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
@hitenkoku Thanks so much for such a quick fix! I confirmed it is working properly!
hitenkoku
deleted the
1148-bug-timeline-start-and-timeline-end-do-not-work-correctly-with-json-timeline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
--timeline-startand--timeline-enddo not work correctly withjson-timelinecommand.I would appreciate it if you could review when you have time.