Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme #1185

Merged
merged 1 commit into from
Sep 30, 2023
Merged

update readme #1185

merged 1 commit into from
Sep 30, 2023

Conversation

fukusuket
Copy link
Collaborator

json-timeline also supports MITER ATT&CK mapping, so I fixed the README :)

I would appreciate it if you could review🙏

@fukusuket fukusuket added the documentation Improvements or additions to documentation label Sep 30, 2023
@fukusuket fukusuket self-assigned this Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b84bd4d) 83.74% compared to head (a30da52) 83.74%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files          26       26           
  Lines       23492    23492           
=======================================
  Hits        19673    19673           
  Misses       3819     3819

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hitenkoku
hitenkoku approved these changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket Thanks for your pull request.
LGTM.

YamatoSecurity
YamatoSecurity approved these changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket Thanks for the fixes! LGTM!

@YamatoSecurity YamatoSecurity merged commit 5b99068 into main Sep 30, 2023
9 checks passed
@fukusuket fukusuket deleted the update-readme-20230930 branch September 30, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hitenkoku hitenkoku hitenkoku approved these changes

@YamatoSecurity YamatoSecurity YamatoSecurity approved these changes

Assignees

@fukusuket fukusuket

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fukusuket @hitenkoku @YamatoSecurity