Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in insert_message. #639 #660

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Fix race condition in insert_message. #639 #660

merged 1 commit into from
Aug 13, 2022

Conversation

fukusuket
Copy link
Collaborator

What Changed

Evidence

Run the following command 5 times and confirm that the number of detections is the same.
hayabusa -d ../hayabusa-sample-evtx -o ...

Attach the command execution results.
test-results.zip

@YamatoSecurity YamatoSecurity self-requested a review August 12, 2022 18:22
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to confirm that the results are stable and the same as version 1.4.1.
Thank you so much for the fix!

Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hitenkoku hitenkoku added the bug Something isn't working label Aug 13, 2022
@kazuminn
Copy link
Collaborator

many thanks.
LGTM.

@kazuminn kazuminn merged commit 0818597 into Yamato-Security:main Aug 13, 2022
@fukusuket fukusuket deleted the fix-race-condition-in-insert-message branch August 13, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] v1.4.2+ Hayabusa will randomly miss a few events
4 participants