Improve TCP communication #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A chunk is read from the network and added to a buffer (recv()), then if the buffer doesn't have enough information, the handler waits for the next `handle_read` call to get more information into the buffer. This works with simultaneous clients. The Redis codebase was the guide for this commit.
Sometimes with non-blocking sockets they can receive EAGAIN, this is for extra safety and to avoid unnecessary crashes
hltbra
added a commit
that referenced
this pull request
Feb 1, 2019
* Improve TCP communication (#15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some issues when I was running stress tests against an EC2 server and realized that I did a terrible job with the TCP communication in the previous releases.
The proper way (copied from Redis) is to ignore half-baked messages and buffer them instead of expecting the communication to have everything ready to go.
The changes in
server.pyaren't covered by tests because I couldn't replicate this issue locally, even with https:/sitespeedio/throttle.