Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RESTORE command #28

Merged
merged 25 commits into from
Jun 7, 2019
Merged

Add RESTORE command #28

merged 25 commits into from
Jun 7, 2019

Conversation

hltbra
Copy link
Contributor

@hltbra hltbra commented Jun 6, 2019

Fixes #26

hltbra added 25 commits June 6, 2019 13:56
Only strings are supported at the moment
There was a problem with the float precision when converting scores to bytes:
```python
    >>> score = 0.22685962236021595
    >>> score
    0.22685962236021595
    >>> bytes(score)
    '0.22685962236'
    >>> to_float_string(score)
    '0.22685962236021595'
```
No need to generate a list of integers for these for loops
This had a major speed bump, probably because it costs Python a lot to allocate new strings and deallocate them eventually
These are in the form of "-BUSYKEY..." instead of "-ERR msg"
With this change, there is no need to translate objects back and forth.
@hltbra hltbra merged commit 4ac3102 into master Jun 7, 2019
@hltbra hltbra deleted the feature/restore branch June 7, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement RESTORE
1 participant