Add support to HSCAN. Fix #46 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A prefix is not the same thing as a starting point. The two concepts were mixed before and it caused a bug where the sorted set would not iterated correctly. This commit includes a regression test.
Hashes with 512 or fewer entries will use a ziplist encoding by default, which changes the behavior of HSCAN to return all entries, regardless of the COUNT parameter. The same applies to sorted sets with 128 or fewer entries. The `+ 100` is to avoid issues with `range()` & off-by-one errors (simpler than adding `+ 1` to the `range()` calls).
The empty string was a shortcut because it is a falsy value in Python, but it did not express the right intentions and required a hack to work with plyvel (it does not accept key_prefix and start arguments together). This commit makes the intentions clear but requires some `None` checks.
This refactoring also makes it easier to add SCAN and SSCAN.
1024 cursors does not seem like a lot and 8x that is still a small number that should fit in memory without too much overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new command
HSCANand fixes a bug withZSCANand start keys.The size of the cursors was bumped to
8 * 1024because 1024 was not a lot of cursors and 8x that isn't a lot of memory space.