Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw slows
ZREM
andHDEL
when running large sorted sets, and that was because of the calls toempty_directory()
(which callsos.listdir()
).In order to not retrieve information about all files in a given directory just to check if the directory is empty, I added the
scandir
package as a dependency. Bothscandir.scandir
andos.listdir()
use the C functionreaddir()
, however, with this pull request,scandir.scandir
will only callreaddir()
once.This showed a ~5% performance improvement for ZREM.