Fixing video playback on Firefox. Using requestAnimationFrame as a fallback for when requestVideoFrameCallback is undefined #416
+62
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queenOfPentacls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing videos in HTML5 on Firefox has really bad laggy playback performance. This is a workaround using
requestAnimationFramewhich is compatible with Firefox/other browsers that don't supportrequestVideoFrameCallback. This was project-ruining on the game I'm working on, so I hope sharing this here will help some other people out who were running into this issue.One thing about this is I'm hardcoding the FPS to 30. I'm not sure if its possible to derive that directly from the video source or if the FPS should be defined inside the video object inside of Gamemaker.
I'm also wrapping the
updateVideoFramefunction in a conditional checking the state ofg_VideoUserEnded, was encountering memory leak issues otherwise but it doesn't feel right to me.