Allow for using the polyfills on PHP 5.4 #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one PHP 5.5 specific syntax being used in this library -
::class
-.This was the only blocker for allowing tests using the polyfills to run on PHP 5.4.
This blocker has now been removed, making the polyfills available on PHP 5.4 in combination with PHPUnit 4.8.x as well.
Note: there are 11 tests being marked as "risky" on PHP 5.4. This is the same on PHP 5.5 and is unrelated to this library, but to do with an underlying issue in the older PHPUnit versions themselves.
I do not consider this a blocker as the tests *will run and do pass.
Details of the tests marked as risky (fold out for details)