Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid double anchor # in urls #21605

Open
2 tasks done
kkmuffme opened this issue Sep 5, 2024 · 3 comments
Open
2 tasks done

Invalid double anchor # in urls #21605

kkmuffme opened this issue Sep 5, 2024 · 3 comments

Comments

@kkmuffme
Copy link

kkmuffme commented Sep 5, 2024

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened

On some pages the URLs have a double anchor e.g. /wp-admin/admin.php?page=wpseo_tools&tool=import-export contains a href="#top#import-seo"

To Reproduce

Step-by-step reproduction instructions

  1. open /wp-admin/admin.php?page=wpseo_tools&tool=import-export
  2. see wrong URL in dev tools

Expected results

  1. only 1 anchor

Actual results

  1. multiple # anchors

This bug can be seen in multiple files in the plugin, e.g. https:/Yoast/wordpress-seo/blob/trunk/admin/class-admin.php#L244

Here's a list of files that have this issue I found with a quick grep:
https:/Yoast/wordpress-seo/blob/trunk/admin/class-admin.php
https:/Yoast/wordpress-seo/blob/trunk/admin/class-option-tabs-formatter.php
https:/Yoast/wordpress-seo/blob/trunk/admin/class-bulk-editor-list-table.php
https:/Yoast/wordpress-seo/blob/trunk/admin/views/tool-bulk-editor.php
https:/Yoast/wordpress-seo/blob/trunk/admin/views/tool-import-export.php
https:/Yoast/wordpress-seo/blob/trunk/admin/views/tabs/tool/wpseo-export.php
https:/Yoast/wordpress-seo/blob/trunk/admin/views/tabs/tool/wpseo-import.php
https:/Yoast/wordpress-seo/blob/trunk/admin/views/tabs/tool/import-seo.php
https:/Yoast/wordpress-seo/blob/trunk/src/integrations/admin/first-time-configuration-notice-integration.php
https:/Yoast/wordpress-seo/blob/trunk/src/integrations/admin/installation-success-integration.php
https:/Yoast/wordpress-seo/blob/trunk/src/integrations/admin/old-configuration-integration.php
https:/Yoast/wordpress-seo/blob/trunk/src/integrations/admin/workouts-integration.php

@josevarghese
Copy link
Contributor

Hi @kkmuffme

Thanks for using the Yoast SEO plugin and for creating an issue. I didn't find any issue with the settings loading of any settings page or causing any issues with having #top#import-seo or the jump links having two # anchors. So, I am closing this issue as it's not causing any issues to the plugin.

@josevarghese josevarghese closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2024
@kkmuffme
Copy link
Author

kkmuffme commented Sep 9, 2024

https://datatracker.ietf.org/doc/html/rfc3986

The # symbol is used to introduce the fragment, and there is only one fragment component allowed, because the specification only allows one # followed by the fragment identifier.
The presence of more than one # symbol is not permitted because only the first # and everything following it is considered part of the fragment identifier.

@josevarghese
Copy link
Contributor

josevarghese commented Sep 10, 2024

Hi @kkmuffme

Thanks for sharing the details. I am re-opening this issue after consulting with our development team.

What's next?
Our product team will assess the severity of this problem in relation to other open bug reports and new features. Based on their assessment, the bug report will be given a priority level. Our developers work on the highest priority issues first. Unfortunately, this means we cannot give you an estimate of when they'll start working on your report.

@josevarghese josevarghese reopened this Sep 10, 2024
@josevarghese josevarghese added Yoast: Management Issues about options and management of the plugin and removed Yoast: Management Issues about options and management of the plugin labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants