ignore configure_optimizers warning #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
=======================================
Coverage 90.69% 90.69%
=======================================
Files 90 90
Lines 6736 6740 +4
=======================================
+ Hits 6109 6113 +4
Misses 627 627 ☔ View full report in Codecov by Sentry. |
adamgayoso
requested changes
May 16, 2021
scvi/train/_trainer.py
Outdated
| @@ -156,4 +156,9 @@ def fit(self, *args, **kwargs): | |||
| category=UserWarning, | |||
| message="One of given dataloaders is None and it will be skipped", | |||
| ) | |||
| warnings.filterwarnings( | |||
There was a problem hiding this comment.
let's only filter it if the model passed to fit is an instance of:
See the pylit API here, model should be the first arg.
https://pytorch-lightning.readthedocs.io/en/latest/common/trainer.html#fit
adamgayoso
requested changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1057