Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scanvi predict typo #1100

Merged
merged 6 commits into from
Jul 15, 2021
Merged

fix scanvi predict typo #1100

merged 6 commits into from
Jul 15, 2021

Conversation

galenxing
Copy link
Contributor

@galenxing galenxing commented Jul 14, 2021

fixes #1092

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #1100 (1d67591) into master (ba22825) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1100   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          91       91           
  Lines        6908     6908           
=======================================
  Hits         6263     6263           
  Misses        645      645           
Impacted Files Coverage Δ
scvi/model/_scanvi.py 93.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba22825...1d67591. Read the comment docs.

docs/release_notes/v0.12.0.rst Outdated Show resolved Hide resolved
Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should add a test...

@adamgayoso adamgayoso merged commit f9a0559 into master Jul 15, 2021
@adamgayoso adamgayoso deleted the scanvi_pred branch July 15, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The scANVI prediction results in an array, not a data frame.
2 participants