Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation to explain how we make releases and backport patches #1129

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

watiss
Copy link
Contributor

@watiss watiss commented Sep 2, 2021

No description provided.

@watiss watiss added this to the 0.14.0 milestone Sep 2, 2021
@watiss watiss linked an issue Sep 2, 2021 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #1129 (202484d) into master (757bc96) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          93       93           
  Lines        7300     7300           
=======================================
  Hits         6579     6579           
  Misses        721      721           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757bc96...202484d. Read the comment docs.

Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I'm not a fan of the extra link in the nav bar. I think all in one for now is fine as within a page you get the right side nav. In the future we can have multiple pages inside "contributing". Thoughts?

@watiss
Copy link
Contributor Author

watiss commented Sep 2, 2021

Personally, I kind of like the separation. This is what Pandas does too: https://pandas.pydata.org/docs/development/maintaining.html. But I'm fine with leaving it as it is today and updating later if we see fit.
Update coming in shortly

Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can make it like Pandas soon (multiple pages within a development tab)

@adamgayoso adamgayoso merged commit ce8fefd into master Sep 2, 2021
@adamgayoso adamgayoso deleted the valehvpa/add_maintenance_docs branch September 2, 2021 20:15
@adamgayoso
Copy link
Member

@meeseeksdev backport to 0.14.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup meeseeksmachine for automated backporting
2 participants