Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if function based pyro module for use_kl_weight #1242

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

justjhong
Copy link
Contributor

Fixes #1241

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #1242 (d8bd388) into master (85fb04a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1242   +/-   ##
=======================================
  Coverage   90.68%   90.69%           
=======================================
  Files          96       96           
  Lines        7754     7759    +5     
=======================================
+ Hits         7032     7037    +5     
  Misses        722      722           
Impacted Files Coverage Δ
scvi/train/_trainingplans.py 95.95% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fb04a...d8bd388. Read the comment docs.

Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justjhong justjhong merged commit ac0c3e0 into master Oct 27, 2021
@justjhong justjhong deleted the jhong/pyrocheck branch October 27, 2021 22:07
@adamgayoso
Copy link
Member

@meeseeksdev backport to 0.14.x

@meeseeksdev
Copy link

meeseeksdev commented Oct 28, 2021 via email

@justjhong
Copy link
Contributor Author

@meeseeksdev is the precursor to commands to this bot: https:/MeeseeksBox/MeeseeksDev. You may want to choose a different username because I am sure others will make the same mistake.

adamgayoso pushed a commit that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyroTrainingPlan kl weight should check if model is a PyroModule or a method
3 participants