Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pyro load history #1255

Merged
merged 3 commits into from
Nov 15, 2021
Merged

fix pyro load history #1255

merged 3 commits into from
Nov 15, 2021

Conversation

adamgayoso
Copy link
Member

Fixes #1245

Copy link
Contributor

@justjhong justjhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #1255 (f85ee4c) into master (c1c3146) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1255   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files          96       96           
  Lines        7761     7761           
=======================================
  Hits         7039     7039           
  Misses        722      722           
Impacted Files Coverage Δ
scvi/model/base/_base_model.py 92.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c3146...f85ee4c. Read the comment docs.

@adamgayoso adamgayoso merged commit 232aeb2 into master Nov 15, 2021
@adamgayoso adamgayoso deleted the pyro_load branch November 15, 2021 18:49
@adamgayoso
Copy link
Member Author

@meeseeksdev backport to 0.14.x

meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Nov 15, 2021
adamgayoso added a commit that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When loading pyro models, auxiliary training step should not be logged to ELBO history
2 participants