Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer when copy detected #1416

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Transfer when copy detected #1416

merged 2 commits into from
Mar 10, 2022

Conversation

justjhong
Copy link
Contributor

Fixes #1409

@codecov
Copy link

codecov bot commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #1416 (867cd27) into master (c20ea20) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
+ Coverage   91.03%   91.04%   +0.01%     
==========================================
  Files         111      111              
  Lines        8632     8635       +3     
==========================================
+ Hits         7858     7862       +4     
+ Misses        774      773       -1
Impacted Files Coverage Δ
scvi/model/base/_base_model.py 89.28% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c20ea20...867cd27. Read the comment docs.

adamgayoso
adamgayoso approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after release note

@justjhong justjhong enabled auto-merge (squash) March 10, 2022 19:29
@justjhong justjhong merged commit de2eac4 into master Mar 10, 2022
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Mar 10, 2022
@justjhong @meeseeksmachine
Backport PR scverse#1416: Transfer when copy detected
aa17083
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 10, 2022
Merged
@justjhong justjhong deleted the jhong/validatefix branch March 10, 2022 19:52
justjhong added a commit that referenced this pull request Mar 10, 2022
@meeseeksmachine @justjhong
Backport PR #1416: Transfer when copy detected (#1418)
ed55e3e 
Co-authored-by: Justin Hong <[email protected]>
nrclaudio pushed a commit to nrclaudio/scvi-tools-tune that referenced this pull request Jun 21, 2022
@justjhong @nrclaudio
transfer when copy detected (scverse#1416)
f2666d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgayoso adamgayoso adamgayoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_validate_anndata should deal with AnnData
2 participants
@justjhong @adamgayoso