Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_likelihood_parameters for n_samples > 1 and dispersion="gene_cell" #1504

Merged
merged 4 commits into from
Apr 8, 2022
Merged

Fix get_likelihood_parameters for n_samples > 1 and dispersion="gene_cell" #1504

merged 4 commits into from
Apr 8, 2022

Conversation

justjhong
Copy link
Contributor

Fixes #874

@codecov
Copy link

codecov bot commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #1504 (bc196c9) into master (fb4b4e0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
+ Coverage   91.07%   91.08%   +0.01%     
==========================================
  Files         112      112              
  Lines        8813     8813              
==========================================
+ Hits         8026     8027       +1     
+ Misses        787      786       -1
Impacted Files Coverage Δ
scvi/model/base/_rnamixin.py 92.10% <100.00%> (ø)
scvi/module/_vae.py 94.42% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4b4e0...bc196c9. Read the comment docs.

@adamgayoso adamgayoso enabled auto-merge (squash) April 8, 2022 18:51
@adamgayoso adamgayoso merged commit 5407e52 into master Apr 8, 2022
@adamgayoso adamgayoso deleted the jhong/iss874 branch May 10, 2022 04:28
nrclaudio pushed a commit to nrclaudio/scvi-tools-tune that referenced this pull request Jun 21, 2022
@justjhong @adamgayoso @nrclaudio
Fix get_likelihood_parameters for n_samples > 1 and `dispersion="…
b018bac 
…gene_cell"` (scverse#1504)

* fix concat for n_samples > 1

* update release note

Co-authored-by: Adam Gayoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgayoso adamgayoso adamgayoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in get_likelihood_parameters with dispersion="gene-cell"
2 participants
@justjhong @adamgayoso