Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1555: update versions of pytorch lightning, jinja, sphinx #1556

Merged
merged 3 commits into from
Jun 4, 2022

Conversation

justjhong
Copy link
Contributor

@justjhong justjhong commented Jun 4, 2022

Note that this backport changes the PR to keep pytorch lightning >1.5 and <=1.6, while adding the upper bound protobuf dependency that pytorch lightning added in 1.6.x

@justjhong justjhong requested a review from adamgayoso June 4, 2022 00:27
@adamgayoso adamgayoso closed this Jun 4, 2022
@adamgayoso
Copy link
Member

Closed as 0.16.x is forced between 1.5 and <1.6 lightning

@adamgayoso adamgayoso deleted the auto-backport-of-pr-1555-on-0.16.x branch June 4, 2022 08:11
@adamgayoso adamgayoso restored the auto-backport-of-pr-1555-on-0.16.x branch June 4, 2022 08:12
@adamgayoso adamgayoso reopened this Jun 4, 2022
pyproject.toml Outdated Show resolved Hide resolved
@adamgayoso adamgayoso enabled auto-merge (squash) June 4, 2022 08:16
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #1556 (ba9eb8c) into 0.16.x (2c7229f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.16.x    #1556   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         112      112           
  Lines        8842     8842           
=======================================
  Hits         8043     8043           
  Misses        799      799           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7229f...ba9eb8c. Read the comment docs.

@adamgayoso adamgayoso merged commit 1db7efc into 0.16.x Jun 4, 2022
@martinkim0 martinkim0 deleted the auto-backport-of-pr-1555-on-0.16.x branch July 4, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants