Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kl weight warning #1773

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Remove kl weight warning #1773

merged 5 commits into from
Oct 31, 2022

Conversation

adamgayoso
Copy link
Member

The kl weight warning is confusing to our users, as it's not clear what the user response should be. I would argue the response should not be more training just to reach the final kl weight, as something like this has never been benchmarked.

As a compromise I've set the kl weight to be logged by lightning.

@adamgayoso adamgayoso enabled auto-merge (squash) October 31, 2022 15:41
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 90.85% // Head: 90.83% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (ddb54d9) compared to base (55048eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1773      +/-   ##
==========================================
- Coverage   90.85%   90.83%   -0.02%     
==========================================
  Files         118      118              
  Lines       10015     9999      -16     
==========================================
- Hits         9099     9083      -16     
  Misses        916      916              
Impacted Files Coverage Δ
scvi/model/base/_training_mixin.py 93.75% <100.00%> (-3.31%) ⬇️
scvi/train/_trainingplans.py 93.73% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamgayoso adamgayoso merged commit e287fc6 into main Oct 31, 2022
@martinkim0 martinkim0 deleted the kl_info branch October 31, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants