Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh: Make auto dns feature optional #581

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Enh: Make auto dns feature optional #581

merged 2 commits into from
Sep 16, 2024

Conversation

Axolotle
Copy link
Contributor

The problem

  • we display suggested DNS records for special-use domains
  • since auth infos for auto DNS push feature are now optional, there's no errors for misconfigured registrar.

Solution

  • display error when the feature is activated
  • hide suggested DNS records for special-use domains
  • do not show that the auto dns are ok when they're not :/

PR Status

OK

Requires: YunoHost/yunohost#1951

@alexAubin alexAubin merged commit 54cbdef into bookworm Sep 16, 2024
1 check passed
@alexAubin alexAubin mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexAubin alexAubin alexAubin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
technical stuff
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Axolotle @alexAubin