Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Feliz.CompilerPlugins version required by Feliz 1 #554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MangelMaxime
Copy link
Contributor

Hello @Zaid-Ajaj,

Important: This PR is not to be merged into master but should instead go into a feliz1 branch. In theory, I created this branch on the latest commit related to v1.

This branch is related to #544. The goal of this branch is to push a new version of Feliz 1 which restrict Feliz.CompilerPlugin to version 1 only.

image

I had to use a custom MSBuild task because MSBuild doesn't support version restriction on ProjectReference out of the box.

NuGet/Home#5556 (comment)

@Zaid-Ajaj
Copy link
Owner

Feliz v2 has been in use for a while now, I don't think I want to maintain a separate Feliz v1.x branch just for this 🤔 I would rather if users updated to Feliz v2 if they encountered issues with v1

@MangelMaxime
Copy link
Contributor Author

@Zaid-Ajaj The problem, is that if they don't use the latest version of Fable 3 then they will only see the problem at the runtime only with some weird errors / behaviours. There was a bug in previous version of Fable 3 which allows to "skip" invalid plugins and keep the compilation going as normal when it should have failed.

We are speaking about a one time release, which can avoid them having to debug strange bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants