Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update support libraries (and drop QueryException) #57

Merged
merged 8 commits into from
Dec 29, 2023
Merged

Update support libraries (and drop QueryException) #57

merged 8 commits into from
Dec 29, 2023

Commits on Dec 29, 2023

  1. Update MetaBrainz.Build.Sdk to v3.1.2

    @Zastai
    Zastai committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5f0d0cc View commit details
    Browse the repository at this point in the history

  2. Update MetaBrainz.Common to v3.0.0

    @Zastai
    Zastai committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    b4ff7e5 View commit details
    Browse the repository at this point in the history

  3. Update MetaBrainz.Common.Json to v6.0.1

    @Zastai
    Zastai committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    020378b View commit details
    Browse the repository at this point in the history

  4. Drop QueryException 

    `MusicBrainz.Common.HttpError` is used instead.
    @Zastai
    Zastai committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    b2a4204 View commit details
    Browse the repository at this point in the history

  5. Add exception documentation 

    All methods that issue a web request are now properly documented as
potentially throwing `HttpRequestException` or `HttpError`.
    @Zastai
    Zastai committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    d3ae5bb View commit details
    Browse the repository at this point in the history

  6. Apply style tweaks 

    These include:

- use of `is [not] null` instead of `==/!= null`
- expression-valued method bodies
    @Zastai
    Zastai committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    745fc63 View commit details
    Browse the repository at this point in the history

  7. Adjust setters on internal objects 

    In the case of `DiskIdLookupResult`, they were replaced by specific
constructors; in all other cases they were changed from `set` to `init`.
    @Zastai
    Zastai committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    7d74624 View commit details
    Browse the repository at this point in the history

  8. Tweak error

    @Zastai
    Zastai committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    6778ae3 View commit details
    Browse the repository at this point in the history