Add transitive reduction algorithm

[nrkramer]

A good pull request has the following information:

• Addresses Add algorithm to compute the transitive reduction #273
• Adds the transitive reduction algorithm and supporting test
• Adds a function for finding an edge within the graph given two nodes
• @mentions of the person or team responsible for reviewing proposed changes. ( optional )
  • @nrkramer

[ghost]

👇 Click on the image for a new way to code review

Legend

[github-advanced-security]

Cppcheck (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

[ZigRazor]

Do you can check if is possible to eliminate at least the "violations" reported by cppcheck?

[nrkramer]

Do you can check if is possible to eliminate at least the "violations" reported by cppcheck?

I've fixed a few of the "violations". Some of them seem intended for C, such as MISRA 17.8, as reference parameter modification is bread-and-butter in C++ (in C++, programmers use const to denote that the reference should not be modified in the function body).

Some of the other violations, such as MISRA 15.5, are necessary as optimizations. Early return from function is common practice to speed up function calls, and refractoring the function to support leaving loops quickly would result in code that is difficult to understand.

I've dismissed the violations on code in which this PR is not concerned, as it is irrelevant to the PR.

[codecov]

Codecov Report

Merging #304 (71011e3) into master (430ce48) will decrease coverage by 0.17%.
The diff coverage is 97.37%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   97.71%   97.55%   -0.17%     
==========================================
  Files          51       53       +2     
  Lines        7189     7449     +260     
==========================================
+ Hits         7025     7267     +242     
- Misses        164      182      +18     

Flag	Coverage Δ
unittests	97.55% <97.37%> (-0.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
include/Graph/Graph.hpp	96.63% <93.33%> (-0.28%)	⬇️
test/MTXTest.cpp	100.00% <100.00%> (ø)
test/TransitiveReductionTest.cpp	100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

[ZigRazor]

Good Job!