Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix mtxtest #309

Merged
merged 4 commits into from
May 24, 2023
Merged

Bugfix mtxtest #309

merged 4 commits into from
May 24, 2023

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented May 24, 2023

Fix the relative path for the test files of the import mtx method, which caused an error in the code coverage workflow (issue #305 )

@github-actions github-actions bot added the test Something about test label May 24, 2023
@ghost
Copy link

ghost commented May 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #309 (4772fa2) into master (430ce48) will decrease coverage by 0.14%.
The diff coverage is 97.68%.

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   97.71%   97.57%   -0.14%     
==========================================
  Files          51       52       +1     
  Lines        7189     7355     +166     
==========================================
+ Hits         7025     7177     +152     
- Misses        164      178      +14     
Flag Coverage Δ
unittests 97.57% <97.68%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/Graph/Graph.hpp 96.79% <95.06%> (-0.13%) ⬇️
test/MTXTest.cpp 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@sbaldu
Copy link
Collaborator Author

sbaldu commented May 24, 2023

I'll add a few tests to address the decrease in coverage

@ZigRazor ZigRazor self-requested a review May 24, 2023 10:48
@ZigRazor ZigRazor added bug Something isn't working CI/CD Continuous Integration/Continuous Development Issue labels May 24, 2023
@ZigRazor ZigRazor linked an issue May 24, 2023 that may be closed by this pull request
@ZigRazor
Copy link
Owner

Good Job! Remember to Sign the commit next time!

@ZigRazor ZigRazor merged commit a5a8acb into ZigRazor:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD Continuous Integration/Continuous Development Issue test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with Test and Code Coverage CI
2 participants