Add documentation for transitive reduction #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrkramer
added
documentation
github-actions
bot
removed
the
documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| [Transitive Reduction](https://en.wikipedia.org/wiki/Transitive_reduction) | ||
|
|
||
| This algorithm is used to construct a directed graph with the same reachability and satisfies transitive closure, with as few edges as possible. More concretely, it creates a minimum equivalent graph with as few edges as possible, removing "short-circuit" paths through the graph. |
Check warning
Code scanning / Markdownlint (reported by Codacy)
Expected: 80; Actual: 280
| foreach z in graph.vertices | ||
| delete edge xz if edges xy and yz exist | ||
|
|
||
| Our implementation has if gates that do early checking for edges in multiple places, which gives it a slightly faster runtime than the cubic pseudocode here. |
Check warning
Code scanning / Markdownlint (reported by Codacy)
Expected: 80; Actual: 157
|
|
||
| This algorithm is used to construct a directed graph with the same reachability and satisfies transitive closure, with as few edges as possible. More concretely, it creates a minimum equivalent graph with as few edges as possible, removing "short-circuit" paths through the graph. | ||
|
|
||
| This is done by iterating through each node-pair, checking to see if two edges exist that leads out of the first node OR out of the last node, removing the node-pair edge if it exists. |
Check warning
Code scanning / Markdownlint (reported by Codacy)
Expected: 80; Actual: 184
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
- Coverage 97.71% 97.61% -0.11%
==========================================
Files 52 53 +1
Lines 7355 7449 +94
==========================================
+ Hits 7187 7271 +84
- Misses 168 178 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ZigRazor
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add documentation for transitive reduction, so I've added here in this PR