Update activity vignette #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natesheehan
reviewed
Sep 13, 2021
| @@ -283,7 +283,8 @@ ab_sf = function( | |||
| sf_data = subset(trip_data, select = -c(origin, destination)) | |||
| sf_linestring = sf::st_sf( | |||
| sf_data, | |||
| geometry = linestrings | |||
| geometry = linestrings, | |||
| crs = 4326 | |||
vignettes/activity.Rmd
Outdated
| od_sf = od::od_to_sf(od, places_sf) | ||
| plot(od_sf["departure"], reset = FALSE, key.pos = 1, lwd = 6:2) | ||
| plot(places_sf$geometry, pch = places$name, add = TRUE, cex =2) | ||
| # mapview::mapview(od_sf["departure"]) | ||
| ``` | ||
|
|
||
| ```{r, eval=FALSE} | ||
| od::od_coordinates(od_sf) | ||
| As an aside, another way of representing the spatial attributes of the OD data with with four columns with 'X' and 'Y' coordinates for both origins and destinations: |
| @@ -146,9 +168,14 @@ That results in the following file: | |||
|
|
|||
| ``` | |||
|
|
|||
| What do the first 2 trips look like? | |||
| You can check the 'round trip' conversion of this JSON representation back into the data frame representation as follows: | |||
|
|
|||
That's what siestas are for! |
natesheehan
approved these changes
Sep 13, 2021
| @@ -189,6 +189,7 @@ ab_json = function( | |||
| "if the original input was in 10,000th of a second (used internally by A/B Street)" | |||
| ) | |||
| } | |||
| desire_lines$departure = desire_lines$departure * 10000 | |||
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.