Replace DIRECTORY_SEPARATOR with '/'

[w00key]

This pull request aims to fix zips created on windows with a broken folder structure which doesn't match the lambda function handler.

[aarondfrancis]

This is a good catch, thank you @w00key!

[ianscotland]

This did not fix for me as once the removeBasePath() was fixed I still ended up with file patterns that look like /resources/lambda\index.js - I had to add a str_replace to flip the \ to a /

    $str = preg_replace('/^' . preg_quote($this->getBasePath(), '/') . '/i', '', $path);
    return str_replace('\\','/', $str);

[w00key]

Hi @ianscotland can you include your code for your LambdaFunction class and I'll try it?

I tested this with a package that didn't replace the base, its possible a custom base path still has issues.

This was my test package, which mirrored the issue I found about windows.

namespace App\Sidecar\Portals\Pulse;

use Hammerstone\Sidecar\Package;
use Hammerstone\Sidecar\LambdaFunction;

class PulseListTasks extends LambdaFunction {

    public function name() {
        return 'Pulse List Tasks';
    }

    public function handler()
    {
        return 'resources/lambda/portals/pulse/list-tasks.handle';
    }
 
    public function package()
    {
        return Package::make()
        ->include([
            'resources/lambda/portals/pulse/list-tasks.js'
        ]);
    }
}

[ianscotland]

Hi Rob, Thanks for getting back so quickly. Here is my Lambda function code – we have multiple files as part of the lambda function so just include the directory which I guess may be the problem namespace App\Sidecar; use Hammerstone\Sidecar\LambdaFunction; class CreateOosPdf extends LambdaFunction { /* Configuration start */ public function runtime() { return "nodejs14.x"; } public function memory() { // 5GB of memory return 5120; } public function timeout() { // 10 minutes return 600; } public function layers() { return [ 'arn:aws:lambda:eu-west-1:764866452798:layer:ghostscript:9', //ghostscipt 'arn:aws:lambda:eu-west-1:440740192066:layer:membrance-fonts:1', //membrance-fonts [uw aws acc] 'arn:aws:lambda:eu-west-1:440740192066:layer:membrance-libraries:8' //membrance-libraries [uw aws acc] ]; } /* Configuration End */ public function handler() { return 'resources/lambda/index.handler'; } public function package() { return [ 'resources/lambda', ]; } } From: Rob Lees ***@***.***> Sent: 17 May 2022 13:08 To: hammerstonedev/sidecar ***@***.***> Cc: Ian Scotland ***@***.***>; Mention ***@***.***> Subject: Re: [hammerstonedev/sidecar] Replace DIRECTORY_SEPARATOR with '/' (PR #69) Hi @ianscotland<https:/ianscotland> can you include your code for your LambdaFunction class and I'll try it? I tested this with a package that didn't replace the base, its possible a custom base path still has issues. This was my test package, which mirrored the issue I found about windows. namespace App\Sidecar\Portals\Pulse; use Hammerstone\Sidecar\Package; use Hammerstone\Sidecar\LambdaFunction; class PulseListTasks extends LambdaFunction { public function name() { return 'Pulse List Tasks'; } public function handler() { return 'resources/lambda/portals/pulse/list-tasks.handle'; } public function package() { return Package::make() ->include([ 'resources/lambda/portals/pulse/list-tasks.js' ]); } } — Reply to this email directly, view it on GitHub<#69 (comment)>, or unsubscribe<https:/notifications/unsubscribe-auth/AA2QDBJ7BPBZD6KTCSMSIA3VKOD3BANCNFSM5VKGZNHQ>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[w00key]

I'll try making a dummy test function later today using the same package function setup that you are using and see if the array based version is different to my using the Package class directly on windows or the directory itself causes it to go awry.

[w00key]

yeah looks like passing it a directory on windows still has issues with generating a zip, I'll try and see if I can make a similar tweak to my first PR to resolve this issue.

[w00key]

I've submitted a PR which hopefully resolves the issue. #73